fix(web-analytics): Create group property filters correctly in hogql property_to_expr #19981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A user who had an internal test filter with group property was not able to use web analytics. Zendesk link
I'm not sure if this has ever worked, maybe it's enough of an edge case that we've just not run into yet.
Changes
Pass group_type_index into the Property constructor
How did you test this code?
I copied the user's filters into my local project, saw the same bug they were having in production (sentry link), this change fixed it.
Also added a unit test which is fixed by this PR